Re: Command Triggers, patch v11

Thom Brown <thom@linux.com>

From: Thom Brown <thom@linux.com>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Dimitri Fontaine <dimitri@2ndquadrant.fr>, pgsql-hackers@postgresql.org, Andres Freund <andres@anarazel.de>, Tom Lane <tgl@sss.pgh.pa.us>
Date: 2012-03-09T15:02:56Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →
  1. Fix SPGiST vacuum algorithm to handle concurrent tuple motion properly.

  2. Remove useless const qualifier

  3. Make executor's SELECT INTO code save and restore original tuple receiver.

On 9 March 2012 14:47, Robert Haas <robertmhaas@gmail.com> wrote:
> On Fri, Mar 9, 2012 at 9:35 AM, Thom Brown <thom@linux.com> wrote:
>> I see your point.  My suggestion to Dimitri in another email was
>> either enable triggers for all commands or none.  At the moment it's
>> only available on utility commands.
>
> Yeah, that's clearly not the best of all possible worlds.  :-)
>
> I think we had better look seriously at postponing this patch to 9.3.
> Your reviewing is obviously moving things forward rapidly, but I think
> it's unrealistic to think this is going to be in a committable state
> any time in the next week or two.

That's unfortunate if that's the case. I'll dedicate any bandwidth
necessary for additional testing as I would really like to see this
get in, but if it transpires there's more outstanding work and
polishing needed than time Dimitri personally has available, then I
guess it'll have to be a 9.3 feature. :'(

-- 
Thom