Re: Command Triggers, patch v11

Thom Brown <thom@linux.com>

From: Thom Brown <thom@linux.com>

To: Dimitri Fontaine <dimitri@2ndquadrant.fr>

Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>

Date: 2012-02-28T13:32:09Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Fix SPGiST vacuum algorithm to handle concurrent tuple motion properly.
- b4af1c25bbc6 9.2.0 cited
Remove useless const qualifier
- 66f0cf7da8ee 9.2.0 cited
Make executor's SELECT INTO code save and restore original tuple receiver.
- dfd26f9c5f37 9.2.0 cited

On 28 February 2012 11:43, Thom Brown <thom@linux.com> wrote:
> On 27 February 2012 19:37, Dimitri Fontaine <dimitri@2ndquadrant.fr> wrote:
>> Thom Brown <thom@linux.com> writes:
>>> CREATE COMMAND TRIGGER test_cmd_trg
>>> BEFORE CREATE SCHEMA,
>>>   CREATE OPERATOR,
>>>   CREATE COLLATION,
>>>   CREATE CAST
>>> EXECUTE PROCEDURE my_func();
>>>
>>> I couldn't drop it completely unless I specified all of those commands.  Why?
>>
>> Because I couldn't find a nice enough way to implement that given the
>> shared infrastructure Robert and Kaigai did put into place to handle
>> dropping of objects.  It could be that I didn't look hard enough, I'll
>> be happy to get back that feature.
>
> Well the problem is that you can add commands to a trigger en masse,
> but you can only remove them one at a time.  Couldn't we at least
> allow the removal of multiple commands at the same time?  The docs you
> wrote suggest you can do this, but you can't.

Also note that as of commit 66f0cf7da8eeaeca4b9894bfafd61789b514af4a
(Remove useless const qualifier) the patch no longer applies due to
changes to src/backend/commands/typecmds.c.

-- 
Thom