Thread

Re: Space missing from EXPLAIN output

Thom Brown <thom@linux.com> — 2025-02-28T17:11:44Z

On Fri, 28 Feb 2025 at 16:54, Fabrízio de Royes Mello
<fabriziomello@gmail.com> wrote:
>
>
> On Fri, Feb 28, 2025 at 1:38 PM Thom Brown <thom@linux.com> wrote:
>>
>> Hi,
>>
>> Commit ddb17e387aa introduced fractional row counts, but the rejigging
>> has introduced a formatting issue:
>>
>> Worker 0:  actual time=34.779..34.780rows=0 loops=1
>>   Buffers: shared hit=1200
>> Worker 1:  actual time=39.737..39.738rows=0 loops=1
>>   Buffers: shared hit=1084
>>
>> A space is missing between the time values and the "rows" label.
>>
>
> Are you sure your main is updated? The current main is 424ededc580b03e1bcf8aff18a735e519c80061f.
>
> Because your patch is not applying:
> main on  main [$]
> ➜ git apply /tmp/fix_explain_analyze_spacing.diff
> error: patch failed: src/backend/commands/explain.c:2075
> error: src/backend/commands/explain.c: patch does not apply
>
> On the current main your change should be on line 2041 and not 2075 according to your patch.

Erk, yes, my main wasn't up-to-date. Thanks for pointing that out.

Rebased and attached.

Thom