Horton

Re: Minmax indexes

Thom Brown <thom@linux.com>

View thread View on postgr.es
From: Thom Brown <thom@linux.com>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2013-09-17T21:17:17Z
Lists: pgsql-hackers 
On 17 September 2013 22:03, Alvaro Herrera <alvherre@2ndquadrant.com> wrote:

> Thom Brown wrote:
>
> Thanks for testing.
>
> > Thanks for the patch, but I seem to have immediately hit a snag:
> >
> > pgbench=# CREATE INDEX minmaxtest ON pgbench_accounts USING minmax (aid);
> > PANIC:  invalid xlog record length 0
>
> Silly mistake I had already made in another patch.  Here's an
> incremental patch which fixes this bug.  Apply this on top of previous
> minmax-1.patch.
>

Thanks.

Hit another issue with exactly the same procedure:

pgbench=# create index minmaxtest on pgbench_accounts using minmax (aid);
ERROR:  lock 176475 is not held

-- 
Thom

Commits

  1. Refactor per-page logic common to all redo routines to a new function.

  2. Reduce use of heavyweight locking inside hash AM.

  3. Scan the buffer pool just once, not once per fork, during relation drop.

  4. Major patch from Thomas Lockhart <Thomas.G.Lockhart@jpl.nasa.gov>