Re: Patch (2): Implement failover on libpq connect level.
Thom Brown <thom@linux.com>
From: Thom Brown <thom@linux.com>
To: Victor Wagner <vitus@wagner.pp.ru>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2015-10-23T21:14:56Z
Lists: pgsql-hackers
On 23 October 2015 at 12:52, Victor Wagner <vitus@wagner.pp.ru> wrote: > On Thu, 22 Oct 2015 14:33:11 +0100 > Thom Brown <thom@linux.com> wrote: > >> On 21 October 2015 at 10:07, Victor Wagner <vitus@wagner.pp.ru> wrote: >> > On 2015.10.14 at 13:41:51 +0300, Victor Wagner wrote: >> > >> >> >> >> Attached patch which implements client library failover and >> >> loadbalancing as was described in the proposal >> >> <20150818041850.GA5092@wagner.pp.ru>. >> >> >> > >> > I'm sending imporoved verison of patch. As Olexander Shulgin noted, >> > previous version of patch lacks support for service files. >> > >> > Now support for service files is implemented and multiple host >> > statements in the service file are allowed. >> >> This is causing breakage: >> >> $ pg_basebackup -v -x -D standby1 -h localhost -p 5532 -U rep_user >> row number 0 is out of range 0..-1 > > It seems that pg_basebackup should always specify readonly attribute > for the connection. > > Your data directory is named standby1, so I suspect > that you are trying to make backup from read-only standby instance of > the base. No, the -D option on pg_basebackup specifies the directory to receive the backup into, not from. This is backing up a primary instance. > Can you check if problem persists in your setup with command > > pg_basebackup -v -x -D standby1 \ > -d "host=localhost port=5532 user=rep_user readonly=1" Yes, this works: $ pg_basebackup -v -x -D standby1 -d "host=localhost port=5532 user=rep_user readonly=1" transaction log start point: 0/2000028 on timeline 1 transaction log end point: 0/2000130 pg_basebackup: base backup completed Thom
Commits
-
libpq: Add target_session_attrs parameter.
- 721f7bd3cbcc 10.0 landed
-
Remove superuser checks in pgstattuple
- fd321a1dfd64 10.0 cited
-
Fix unwanted flushing of libpq's input buffer when socket EOF is seen.
- c405918858c0 9.6.0 cited