Thread

Re: split func.sgml to separated individual sgml files

Florents Tselai <florents.tselai@gmail.com> — 2025-09-03T12:16:35Z

On Tue, Sep 2, 2025 at 5:54 PM Andrew Dunstan <andrew@dunslane.net> wrote:

>
> On 2025-09-01 Mo 11:44 AM, Florents Tselai wrote:
>
>
>
> On 1 Sep 2025, at 4:35 PM, Euler Taveira <euler@eulerto.com> wrote:
>
> On Mon, Sep 1, 2025, at 7:35 AM, Florents Tselai wrote:
>
> While working on this https://commitfest.postgresql.org/patch/6020/
> I discovered that when changing for func/func-aggregate.sgml, the HTML
> wasn’t marked for update.
>
> IIUC the doc/Makefile should be updated as attached, right ?
>
>
> Good catch.
>
> However, your patch doesn't fix all issues. The check target (check-tabs
> and
> check-nbsp) is broken; these targets should also include the func files.
>
>
> Ah, you’re right, but then again,  I’d expect ALL_SGML to be used
> consistently, but it isn't and I didn't check.
> v3 does that.
> Note that GENERATED_SGML where'te included in these two targets but I
> think there's no harm in checking them too.
>
>
>
>
> Do we actually care about those? I don't want to add needless cycles
> anywhere. I note that the meson.build doesn't appear to have a check target
> at all, or anything that looks for hard tabs or nbsps.Those checks were
> added to the Makefile back in October in commit 5b7da5c261d, but that got
> missed even though Daniel had mentioned it in the discussion thread.[1]
>

From the message and discussion  in 5b7da5c261d it looks like we do;
and I've seen some messages here and there that people have indeed trouble
applying patches due to spurious whitespace
and special chars.
So I assume the better solution would be having such checks in meson too,