Thread

Re: Inconsistent trigger behavior between two temporal leftovers

Paul A Jungwirth <pj@illuminatedcomputing.com> — 2026-05-05T21:48:10Z

On Tue, May 5, 2026 at 2:16 PM Zsolt Parragi <zsolt.parragi@percona.com> wrote:
>
> + /*
> + * Re-copy the original row into leftoverSlot because
> + * ExecInsert may pass leftoverSlot to BEFORE INSERT
> + * triggers, which can modify the slot contents.
> + */
>
> Shouldn't this mention BEFORE ROW INSERT triggers? Everywhere else the
> comments/commit message/test is specific about this.

I agree being specific is helpful. Here is an updated patch.

Yours,

-- 
Paul              ~{:-)
pj@illuminatedcomputing.com