Re: Fix GetOperatorFromCompareType

Paul A Jungwirth <pj@illuminatedcomputing.com>

View thread

From: Paul A Jungwirth <pj@illuminatedcomputing.com>

To: Neil Chen <carpenter.nail.cz@gmail.com>

Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>

Date: 2025-11-20T16:44:57Z

Lists: pgsql-hackers

Attachments

v2-0001-Improve-comment-and-error-handling-in-GetOperator.patch (application/octet-stream)

On Sun, Nov 16, 2025 at 11:18 PM Neil Chen <carpenter.nail.cz@gmail.com> wrote:
> After your patch changes, the line '*opid = InvalidOid;' seems removable.
>
> Also, if the second validation check of opclass after 'get_opclass_method' feels a bit odd, moving 'get_opclass_opfamily_and_input_type' to the very top would work -- purely for visual clarity. ：）

Thanks for the review! Here is a patch with your suggestions incorporated.

Yours,

-- 
Paul              ~{:-)
pj@illuminatedcomputing.com