Horton

Thread

Commits

  1. doc: Update header file mention for CompareType

  2. Move CompareType to separate header file

  1. doc: Fix the header file where CompareType is defined in gist.sgml

    Daisuke Higuchi <higuchi.daisuke11@gmail.com> — 2025-12-13T08:24:48Z

    Hi

I found that the header file where CompareType was actually defined did not
match the header file described in gist.sgml.
CompareType is currently defined at "src/include/access/cmptype.h" instead
of "src/include/nodes/primnodes.h".
This change was made in the commit below, but it seems that documentation
update was missed.

https://github.com/postgres/postgres/commit/119fc30dd5bd918819b864107ddc8baac51f4d22

Regards

  2. Re: doc: Fix the header file where CompareType is defined in gist.sgml

    Paul A Jungwirth <pj@illuminatedcomputing.com> — 2025-12-15T23:19:34Z

    On Sat, Dec 13, 2025 at 12:25 AM Daisuke Higuchi
<higuchi.daisuke11@gmail.com> wrote:
>
> I found that the header file where CompareType was actually defined did not match the header file described in gist.sgml.
> CompareType is currently defined at "src/include/access/cmptype.h" instead of "src/include/nodes/primnodes.h".
> This change was made in the commit below, but it seems that documentation update was missed.
>
> https://github.com/postgres/postgres/commit/119fc30dd5bd918819b864107ddc8baac51f4d22

You're right, that's where we define it. Your email landed in Gmail's
spam folder for me, so hopefully this +1 will help it not be missed by
a committer.

Yours,

-- 
Paul              ~{:-)
pj@illuminatedcomputing.com

  3. Re: doc: Fix the header file where CompareType is defined in gist.sgml

    Daniel Gustafsson <daniel@yesql.se> — 2025-12-16T08:50:22Z

    > On 16 Dec 2025, at 00:19, Paul A Jungwirth <pj@illuminatedcomputing.com> wrote:
> 
> On Sat, Dec 13, 2025 at 12:25 AM Daisuke Higuchi
> <higuchi.daisuke11@gmail.com> wrote:
>> 
>> I found that the header file where CompareType was actually defined did not match the header file described in gist.sgml.
>> CompareType is currently defined at "src/include/access/cmptype.h" instead of "src/include/nodes/primnodes.h".
>> This change was made in the commit below, but it seems that documentation update was missed.
>> 
>> https://github.com/postgres/postgres/commit/119fc30dd5bd918819b864107ddc8baac51f4d22
> 
> You're right, that's where we define it. Your email landed in Gmail's
> spam folder for me, so hopefully this +1 will help it not be missed by
> a committer.

Thanks for the report, fixing it right now.

--
Daniel Gustafsson