Re: Segfault when restoring -Fd dump on current HEAD
Dmitry Dolgov <9erthalion6@gmail.com>
From: Dmitry Dolgov <9erthalion6@gmail.com>
To: Andres Freund <andres@anarazel.de>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Alvaro Herrera <alvherre@2ndquadrant.com>, Michael Paquier <michael@paquier.xyz>, Justin Pryzby <pryzby@telsasoft.com>, Hubert Lubaczewski <depesz@depesz.com>, pgsql-hackers mailing list <pgsql-hackers@postgresql.org>
Date: 2019-03-10T21:38:10Z
Lists: pgsql-hackers
Attachments
- 0001-ArchiveEntry-null-handling.patch (application/octet-stream) patch 0001
> On Mon, Mar 4, 2019 at 7:15 PM Andres Freund <andres@anarazel.de> wrote: > > The pluggable storage patchset contains exactly that... I've attached > the precursor patch (CREATE ACCESS METHOD ... TYPE TABLE), and the patch > for pg_dump support. They need a bit more cleanup, but it might be > useful information for this thread. Didn't expect this to happen so quickly, thanks! > On 2019-03-04 13:25:40 -0500, Tom Lane wrote: > > Andres Freund <andres@anarazel.de> writes: > > > > > > But it does basically require breaking archive compatibility. I > > > personally am OK with that, but I thought it might be worth discussing. > > > > I don't recall there being huge pushback when we did that in the past, > > so I'm fine with it as long as there's an identifiable feature making > > it necessary. > > Cool. Then I guess we need to add the attached patch on top of a pg_dump support for table am. It contains changes to use NULL as a default value for owner / defn / dropStmt (exactly what we've changed back in 19455c9f56), and doesn't crash, since K_VERS is different.
Commits
-
pg_dump: store unused attribs as NULL instead of '\0'
- 7fcdb5e00214 12.0 landed
-
pg_dump: Fix ArchiveEntry handling of some empty values
- 19455c9f5606 12.0 landed