Re: ArchiveEntry optional arguments refactoring
Dmitry Dolgov <9erthalion6@gmail.com>
From: Dmitry Dolgov <9erthalion6@gmail.com>
To: Andres Freund <andres@anarazel.de>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Alvaro Herrera <alvherre@2ndquadrant.com>, Chapman Flack <chap@anastigmatix.net>,
Amit Khandekar <amitdkhan.pg@gmail.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2019-01-24T12:12:40Z
Lists: pgsql-hackers
Attachments
- 0001-ArchiveOpts-structure_v2.patch (application/octet-stream) patch v2-0001
Here is another version, where I accumulated all the suggestions: * Use NULL as a default value where it was an empty string before (this required few minor changes for some part of the code outside ArchiveEntry) * Rename defn, descr to createStmt, description * Use a macro to avoid pgindent errors About the last one. I'm also inclined to use the simpler version of ARCHIVE_OPTS macro, mostly because the difference between "optional" and "positional" arguments in the alternative proposal is not that visible. So > mixing struct arguments and normal function arguments seems > quite confusing could probably affect not only readability, but also would be bit more problematic for updating this code (which was the goal in the first place).
Commits
-
Add ArchiveOpts to pass options to ArchiveEntry
- f831d4accda0 12.0 landed
-
Remove WITH OIDS support, change oid catalog column visibility.
- 578b229718e8 12.0 cited