Horton

Re: de-deduplicate code in DML execution hooks in postgres_fdw

Dmitry Dolgov <9erthalion6@gmail.com>

View thread View on postgr.es
From: Dmitry Dolgov <9erthalion6@gmail.com>
To: fujita.etsuro@lab.ntt.co.jp
Cc: Ashutosh Bapat <ashutosh.bapat@enterprisedb.com>, Michael Paquier <michael@paquier.xyz>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2018-11-29T17:58:07Z
Lists: pgsql-hackers 
> On Mon, Oct 1, 2018 at 2:55 PM Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp> wrote:
>
> (2018/10/01 19:42), Michael Paquier wrote:
> > On Mon, Jul 23, 2018 at 02:17:38PM +0530, Ashutosh Bapat wrote:
> > Fujita-san, you are registered as a reviewer of this patch.  Are you
> > planning to look at it soon?
>
> Yeah, I'm planning to work on this immediately after fixing the issue
> [1], because it still seems to me wise to work on it after addressing
> that issue.  (I'll post an updated version of the patch for that tomorrow.)

Yep, it would be nice to have a full review here. But as far as I see the issue
you were talking about is still in progress, right? Also looks like someone
needs to take over this rather small patch.

Commits

  1. postgres_fdw: Remove duplicate code in DML execution callback functions.