Horton

Re: pgsql: Add 'basebackup_to_shell' contrib module.

Thomas Munro <thomas.munro@gmail.com>

View thread View on postgr.es
From: Thomas Munro <thomas.munro@gmail.com>
To: Andres Freund <andres@anarazel.de>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Robert Haas <robertmhaas@gmail.com>, Andrew Dunstan <andrew@dunslane.net>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Magnus Hagander <magnus@hagander.net>
Date: 2022-03-30T18:07:21Z
Lists: pgsql-hackers 
On Thu, Mar 31, 2022 at 5:23 AM Andres Freund <andres@anarazel.de> wrote:
> On 2022-03-26 13:51:35 -0700, Andres Freund wrote:
> > Prototype patch attached.
>
> Because I forgot about cfbot when attaching the patch, cfbot actually ran with
> it under this thread's cf entry.  It does look like an improvement to me:
> https://cirrus-ci.com/task/6397292629458944?logs=test_world#L900
>
> We certainly can do better, but it's sufficiently better than what we have
> right now. So I'd like to commit it?

Nice, this will save a lot of time scrolling around trying to figure
out what broke.

> > Would we want to do this in all branches? I'd vote for yes, but ...
>
> Unless somebody speaks in favor of doing this across branches, I'd just go for
> HEAD.

I don't see any reason not to do it on all branches.  If anyone is
machine-processing the output and cares about format changes they will
be happy about the improvement.

Commits

  1. Print information about type of test and subdirectory before running tests.

  2. In basebackup_to_shell tests, properly set up pg_hba.conf.

  3. Add .gitignore for basebackup_to_shell.

  4. basebackup_to_shell: Add TAP test.

  5. Document basebackup_to_shell.required_role.

  6. Add 'basebackup_to_shell' contrib module.