Horton

Re: Bump MIN_WINNT to 0x0600 (Vista) as minimal runtime in 16~

Thomas Munro <thomas.munro@gmail.com>

View thread View on postgr.es
From: Thomas Munro <thomas.munro@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Justin Pryzby <pryzby@telsasoft.com>, Andrew Dunstan <andrew@dunslane.net>, Daniel Gustafsson <daniel@yesql.se>, Juan José Santamaría Flecha <juanjo.santamaria@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2022-09-11T21:42:25Z
Lists: pgsql-hackers 
On Sun, Sep 11, 2022 at 12:29 PM Michael Paquier <michael@paquier.xyz> wrote:
> On Fri, Sep 09, 2022 at 08:11:09PM +0900, Michael Paquier wrote:
> > Based on what I can see, the Windows animals seem to have digested
> > 47bd0b3 (cygwin, MinGW and MSVC), so I think that we are good.

Great, that's a lot of nice cleanup.

> The last part that's worth adjusting is ldap_start_tls_sA(), which
> would lead to the attached simplification.

-        if ((r = _ldap_start_tls_sA(*ldap, NULL, NULL, NULL, NULL))
!= LDAP_SUCCESS)
+        if ((r = ldap_start_tls_sA(*ldap, NULL, NULL, NULL, NULL)) !=
LDAP_SUCCESS)

When looking the function up it made sense to use the name ending in
'...A', but when calling directly I think we shouldn't use the A
suffix, we should let the <winldap.h> macros do that for us[1].  (I
wondered for a moment if that would even make Windows and Unix code
the same, but sadly not due to the extra NULL arguments.)

[1] https://docs.microsoft.com/en-us/windows/win32/api/winldap/nf-winldap-ldap_start_tls_sa

Commits

  1. doc: Fix incorrect version list for Windows SDK

  2. Replace loading of ldap_start_tls_sA() by direct function call

  3. Replace load of functions by direct calls for some WIN32

  4. Cleanup more code and comments related to Windows NT4 (XP days)

  5. Make Windows 10 the minimal runtime requirement for WIN32