Improving the comments in pqsignal()
Thomas Munro <thomas.munro@gmail.com>
From: Thomas Munro <thomas.munro@gmail.com>
To: pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2023-11-23T22:33:29Z
Lists: pgsql-hackers
Attachments
- 0001-Improve-comments-about-pqsignal.patch (text/x-patch) patch 0001
Hi, While following along with Tristan and Heikki's thread about signals in psql, it occurred to me that the documentation atop pqsignal() is not very good: * we don't explain what problem it originally solved * we don't explain why it's still needed today * we don't explain what else it does for us today * we describe the backend implementation for Windows incorrectly (mea culpa) * we vaguely mention one issue with Windows frontend code, but I think the point made is misleading, and we don't convey the scale of the differences Here is my attempt to improve it.
Commits
-
Improve comments about pqsignal().
- 262454be9a62 17.0 landed