Re: BUG #18940: PostgreSQL 18beta1 fails 'collate.windows.win1252' regression when building with MSYS/mingw

Thomas Munro <thomas.munro@gmail.com>

View thread

From: Thomas Munro <thomas.munro@gmail.com>

To: Andres Freund <andres@anarazel.de>

Cc: Joseph Ayers <joseph.ayers@crunchydata.com>, pgsql-bugs@lists.postgresql.org

Date: 2025-06-06T12:17:32Z

Lists: pgsql-bugs

Attachments

0001-Require-UCRT-on-Windows-remove-MSVCRT-traces.patch (text/x-patch) patch 0001
0002-fixup.patch (text/x-patch) patch 0002

On Thu, Jun 5, 2025 at 4:32 AM Andres Freund <andres@anarazel.de> wrote:
> I would *strongly* advise to moving to ucrt. Personally I think we should just
> refuse to build with msvcrt.

Yeah, I didn't realise that it'd still build but not work correctly,
so +1 for adding an #error like the attached.  The attached passed on
CI in the MinGW and Visual Studio tasks (and in passing removes some
more trace of msvcrt), but the Debian cross-compilation step helpfully
shows how it fails with an msvcrt build:

https://cirrus-ci.com/task/4559077411389440

It cross-builds successfully on my local Debian system after
installing these packages:

gcc-mingw-w64-ucrt64
g++-mingw-w64-ucrt64

... and selecting those compilers, as shown in the attached fixup.  So
I think we'll first need to get them added to the CI image, in here:

https://github.com/anarazel/pg-vm-images/blob/main/scripts/linux_debian_install_deps.sh

And then we could push something like this.