Re: Windows pg_basebackup unable to create >2GB pg_wal.tar tarballs ("could not close file: Invalid argument" when creating pg_wal.tar of size ~ 2^31 bytes)

Thomas Munro <thomas.munro@gmail.com>

From: Thomas Munro <thomas.munro@gmail.com>

To: Andrew Dunstan <andrew@dunslane.net>

Cc: Robert Haas <robertmhaas@gmail.com>, Jakub Wartak <jakub.wartak@enterprisedb.com>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>, Dilip Kumar <dilip.kumar@enterprisedb.com>

Date: 2025-01-06T20:54:49Z

Lists: pgsql-hackers

On Tue, Jan 7, 2025 at 5:23 AM Andrew Dunstan <andrew@dunslane.net> wrote:
> Do you have a plan for moving ahead with this?

I think that all looks good, and I'll go ahead and commit it in the
next day or two.  Sorry for the delay.

Commits

Fix off_t overflow in pg_basebackup on Windows.
- bd0564f61d37 13.19 landed
- 8f40d46126a0 14.16 landed
- 6b6901a26f56 15.11 landed
- be7489662e77 16.7 landed
- faee3185aafa 17.3 landed
- 970b97eeb8f0 18.0 landed
Provide 64-bit ftruncate() and lseek() on Windows.
- 026762dae39d 18.0 landed
- af109e3399b6 17.3 landed
- 0bff6f1da842 16.7 landed
- 70a7a37610f7 15.11 landed
- 1636c5e56ed7 14.16 landed
- d02486cc8e0a 13.19 landed
Require ucrt if using MinGW.
- 1758d4244616 18.0 cited