Thread

Re: [PATCH] O_CLOEXEC not honored on Windows - handle inheritance chain

Thomas Munro <thomas.munro@gmail.com> — 2025-12-21T10:41:51Z

On Sun, Dec 14, 2025 at 6:09 PM Thomas Munro <thomas.munro@gmail.com> wrote:
> My earlier guess about the Makefile was wrong, and when I looked into
> it the actual problems were (1) that the CompilerWarnings task in CI
> runs make world-bin, which doesn't descend into src/test, and (2) that
> the test ifeq ($(PORTNAME), win32) was not satisfied due to make's
> rules for variable evaluation.  I thought about how to fix that but
> realised that this is going to be much easier to maintain if it's not
> different on Unix, so here are some fixes in that direction.  With
> just 0001 and 0002 applied, we'd have known about the compiler warning
> before commit, with a failure like this:

I pushed the cleanup patch.

I wondered if there might be any other C code that could be checked
for compiler warnings by CI and isn't yet, and the only thing I have
some up with so far is the .pgc -> .c stuff.  Here is a new version
that does that too.  I also back-patched a fix for a warning (see
eab2323c) that would break if we back-patched this.  Is there anything
else like this hiding somewhere?