Re: Understanding, testing and improving our Windows filesystem code

Thomas Munro <thomas.munro@gmail.com>

View thread View on postgr.es

From: Thomas Munro <thomas.munro@gmail.com>

To: pgsql-hackers <pgsql-hackers@postgresql.org>

Cc: Andres Freund <andres@anarazel.de>

Date: 2022-10-25T04:11:55Z

Lists: pgsql-hackers

Attachments

v3-0001-Add-suite-of-macros-for-writing-TAP-tests-in-C.patch (text/x-patch) patch v3-0001
v3-0002-meson-Add-infrastructure-for-TAP-tests-written-in.patch (text/x-patch) patch v3-0002
v3-0003-Add-tests-for-Windows-filesystem-code-in-src-port.patch (text/x-patch) patch v3-0003
v3-0004-Use-POSIX-semantics-for-unlink-and-rename-on-Wind.patch (text/x-patch) patch v3-0004

I pushed the bug fixes from this series, without their accompanying
tests.  Here's a rebase of the test suite, with all those tests now
squashed into the main test patch, and also the
tell-Windows-to-be-more-like-Unix patch.  Registered in the
commitfest.

Commits

Update obsolete multixact.c comments.
- 5212d447fa53 16.0 cited
Fix unlink() for STATUS_DELETE_PENDING on Windows.
- e109e43921d2 16.0 landed
Fix readlink() for non-PostgreSQL junction points on Windows.
- f71007fbb3b8 16.0 landed
Fix stat() for recursive junction points on Windows.
- 4517358ee782 16.0 landed
Fix lstat() for broken junction points on Windows.
- 387803d81d62 16.0 landed
Fix readlink() return value on Windows.
- 4650036f5ab8 16.0 landed