Horton

Re: LLVM compile failing in seawasp

Thomas Munro <thomas.munro@gmail.com>

View thread View on postgr.es
From: Thomas Munro <thomas.munro@gmail.com>
To: Fabien COELHO <coelho@cri.ensmp.fr>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, didier <did447@gmail.com>, Alvaro Herrera <alvherre@2ndquadrant.com>, Pg Hackers <pgsql-hackers@lists.postgresql.org>, buildfarm@coelho.net
Date: 2019-07-27T09:40:35Z
Lists: pgsql-hackers

Attachments

On Sat, Jul 27, 2019 at 7:12 PM Thomas Munro <thomas.munro@gmail.com> wrote:
> On Sat, Jul 27, 2019 at 7:06 PM Fabien COELHO <coelho@cri.ensmp.fr> wrote:
> > Maybe we should consider doing an explicit bug report, but I would not bet
> > that they are going to fold… or fixing the issue pg side, eg "pg_Min",
> > less than 400 hundred instances, and backpatch to all supported
> > versions:-(
>
> I would just #undef Min for our small number of .cpp files that
> include LLVM headers.  It's not as though you need it in C++, which
> has std::min() from <algorithm>.

Like so.  Fixes the problem for me (llvm-devel-9.0.d20190712).

-- 
Thomas Munro
https://enterprisedb.com

Commits

  1. Avoid macro clash with LLVM 9.