Horton

Re: Cannot find a working 64-bit integer type on Illumos

Thomas Munro <thomas.munro@gmail.com>

View thread View on postgr.es
From: Thomas Munro <thomas.munro@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Daniel Gustafsson <daniel@yesql.se>, Nathan Bossart <nathandbossart@gmail.com>, Peter Eisentraut <peter@eisentraut.org>, Tomas Vondra <tomas@vondra.me>, Heikki Linnakangas <hlinnaka@iki.fi>, Japin Li <japinli@hotmail.com>, Andres Freund <andres@anarazel.de>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2025-04-10T07:20:17Z
Lists: pgsql-hackers 
On Wed, Mar 26, 2025 at 12:36 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Daniel Gustafsson <daniel@yesql.se> writes:
> >> On 26 Mar 2025, at 00:01, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> >> How did that work before?  Perhaps somebody just now added a libpq
> >> dependency to pg_regress.c?
>
> > I believe the libpq dependency came in 66d6086cbcbfc8 which wasn't all that
> > recent.
>
> It looks like this has been broken for a very long time, but it must
> never have mattered before because libpq-fe.h is so stable, and
> pg_regress doesn't use any new-ish APIs from it.  So pulling in
> whatever version the platform had still worked.
>
> I think this should work to fix it:
>
> -pg_regress.o: override CPPFLAGS += -I$(top_builddir)/src/port -I$(libpq_srcdir) $(EXTRADEFS)
> +pg_regress.o: override CPPFLAGS := -I$(top_builddir)/src/port -I$(libpq_srcdir) $(EXTRADEFS) $(CPPFLAGS)
>
> but I haven't tested yet.

Our meson scripts also have this problem, which I couldn't figure out
how to fix completely in my first attempt:

https://www.postgresql.org/message-id/flat/CA%2BhUKGKispvxLyrBn3%3D3mp0BB1N%2BRBYR5eE2guCOksnwEoOcPQ%40mail.gmail.com

Commits

  1. Move pg_int64 back to postgres_ext.h

  2. pgbench: Make set_random_seed() 64-bit everywhere.

  3. Use PRI?64 instead of "ll?" in format strings (continued).

  4. Fix order of -I switches for building pg_regress.o.

  5. libpq: Deprecate pg_int64.

  6. Use PRI*64 instead of "ll*" in format strings (minimal trial)

  7. Fix header inclusion order in c.h.

  8. Use <stdint.h> and <inttypes.h> for c.h integers.

  9. Remove traces of BeOS.

  10. More correct way to check for existence of types, which allows to specify