Horton

Re: BUG #17928: Standby fails to decode WAL on termination of primary

Thomas Munro <thomas.munro@gmail.com>

View thread
From: Thomas Munro <thomas.munro@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Sergei Kornilov <sk@zsrv.org>, Noah Misch <noah@leadboat.com>, Tom Lane <tgl@sss.pgh.pa.us>, Kyotaro Horiguchi <horikyota.ntt@gmail.com>, exclusion@gmail.com, pgsql-bugs@lists.postgresql.org, Fujii Masao <masao.fujii@oss.nttdata.com>
Date: 2023-09-12T02:08:09Z
Lists: pgsql-bugs

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Correct assertion and comments about XLogRecordMaxSize.

  2. Fix edge-case for xl_tot_len broken by bae868ca.

  3. Don't use Perl pack('Q') in 039_end_of_wal.pl.

  4. Don't trust unvalidated xl_tot_len.

  5. Make recovery report error message when invalid page header is found.

  6. Add more protections in WAL record APIs against overflows

On Tue, Sep 12, 2023 at 1:01 PM Michael Paquier <michael@paquier.xyz> wrote:
> On Tue, Sep 05, 2023 at 01:13:16PM +0900, Michael Paquier wrote:
> > Right.  Let's wait for a bit and see if there are any comments on this
> > point.  With 16.0 in sight next week, I'd like to propose that we move
> > on with this issue once next week's tag is pushed.
>
> Hearing nothing, I have applied the backpatch of 0668719801 to 12~14.
> Please find attached the remaining patches for all the stable
> branches.

Thanks!

> Thomas, would you prefer handling that yourself once 16.0 is tagged
> with a last round of checks?  Or should I?  (Still need to edit the
> commit message a bit..)

I'll do that (and update the message).  Thanks for all the help!