Rename ExtendedBufferWhat in 16?
Thomas Munro <thomas.munro@gmail.com>
From: Thomas Munro <thomas.munro@gmail.com>
To: pgsql-hackers <pgsql-hackers@postgresql.org>
Cc: Andres Freund <andres@anarazel.de>
Date: 2023-08-12T00:29:05Z
Lists: pgsql-hackers
Attachments
- 0001-ExtendBufferedWhat-BufferedObjectSelector.patch (text/x-patch) patch 0001
Hi Commit 31966b15 invented a way for functions dealing with relation extension to accept a Relation in online code and an SMgrRelation in recovery code (instead of using the earlier FakeRelcacheEntry concept). It seems highly likely that future new bufmgr.c interfaces will face the same problem, and need to do something similar. Let's generalise the names so that each interface doesn't have to re-invent the wheel? ExtendedBufferWhat is also just not a beautiful name. How about BufferedObjectSelector? That name leads to macros BOS_SMGR() and BOS_REL(). Could also be BufMgrObject/BMO, ... etc etc. This is from a patch-set that I'm about to propose for 17, which needs one of these too, hence desire to generalise. But if we rename them in 17, then AM authors, who are likely to discover and make use of this interface, would have to use different names for 16 and 17.
Commits
-
ExtendBufferedWhat -> BufferManagerRelation.
- f58af9f416f9 16.0 landed
- 711479115836 17.0 landed
-
bufmgr: Introduce infrastructure for faster relation extension
- 31966b151e6a 16.0 cited