Horton

Re: Detection of hadware feature => please do not use signal

Thomas Munro <thomas.munro@gmail.com>

View thread View on postgr.es
From: Thomas Munro <thomas.munro@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Heikki Linnakangas <hlinnaka@iki.fi>, Bastien Roucariès <rouca@debian.org>, pgsql-bugs@lists.postgresql.org
Date: 2024-11-25T00:47:06Z
Lists: pgsql-bugs 
On Mon, Nov 25, 2024 at 12:34 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> I wonder whether "armv8-a" includes FP on aarch64 but not arm32, and
> we only did the original testing of f044d71e3 on aarch64.  If so,
> it might've been like this all along and we didn't notice.

It does work on the "armv7" target BF animals, though.  I assume they
don't get any updates as they're all old/defunct distros (one of my
favourite features of our boneyard^Wbuildfarm), but one of them is GCC
"10.2.1 20210110", which is what made me suspicious of that -mfpu
stuff, beyond my comprehension without a lot more coffee, that got
backpatched in late 2021.

Commits

  1. Update configure probes for CFLAGS needed for ARM CRC instructions.

  2. Support runtime CRC feature probing on NetBSD/ARM using sysctl().

  3. Use auxv to check for CRC32 instructions on ARM.

  4. Improve our method for probing the availability of ARM CRC instructions.