Re: check_strxfrm_bug()
Thomas Munro <thomas.munro@gmail.com>
From: Thomas Munro <thomas.munro@gmail.com>
To: pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2022-12-17T21:27:02Z
Lists: pgsql-hackers
On Thu, Dec 15, 2022 at 3:22 PM Thomas Munro <thomas.munro@gmail.com> wrote: > ... If you're worried that the bugs might > come back, then the test is insufficient: modern versions of both OSes > have strxfrm_l(), which we aren't checking. With my garbage collector hat on, that made me wonder if there was some more potential cleanup here: could we require locale_t yet? The last straggler systems on our target OS list to add the POSIX locale_t stuff were Solaris 11.4 (2018) and OpenBSD 6.2 (2018). Apparently it's still too soon: we have two EOL'd OSes in the farm that are older than that. But here's an interesting fact about wrasse, assuming its host is gcc211: it looks like it can't even apply further OS updates because the hardware[1] is so old that Solaris doesn't support it anymore[2]. [1] https://cfarm.tetaneutral.net/machines/list/ [2] https://support.oracle.com/knowledge/Sun%20Microsystems/2382427_1.html
Commits
-
Don't expose Windows' mbstowcs_l() and wcstombs_l().
- 4e9fa6d56b3e 17.0 landed
-
All supported systems have locale_t.
- 8d9a9f034e92 17.0 landed
-
Remove obsolete defense against strxfrm() bugs.
- 7d3d72b55edd 16.0 landed