Horton

Thread

Commits

  1. Suppress variable-set-but-not-used warning from clang 13.

  1. Warning in geqo_main.c from clang 13

    Thomas Munro <thomas.munro@gmail.com> — 2021-11-24T02:31:49Z

    Hi,

Clang 13 on my machine and peripatus (but not Apple clang 13 on eg
sifika, I'm still confused about Apple's versioning but I think that's
really llvm 12-based) warns:

geqo_main.c:86:8: warning: variable 'edge_failures' set but not used
[-Wunused-but-set-variable]
        int                     edge_failures = 0;

Here's one way to silence it.

  2. Re: Warning in geqo_main.c from clang 13

    Tom Lane <tgl@sss.pgh.pa.us> — 2021-11-24T03:17:54Z

    Thomas Munro <thomas.munro@gmail.com> writes:
> Clang 13 on my machine and peripatus (but not Apple clang 13 on eg
> sifika, I'm still confused about Apple's versioning but I think that's
> really llvm 12-based) warns:
> geqo_main.c:86:8: warning: variable 'edge_failures' set but not used
> [-Wunused-but-set-variable]
>         int                     edge_failures = 0;

Yeah, I noticed that a week or two ago, but didn't see a simple fix.

> Here's one way to silence it.

I'm kind of inclined to just drop the edge_failures recording/logging
altogether, rather than make that rats-nest of #ifdefs even worse.
It's not like anyone has cared about that number in the last decade
or two.

			regards, tom lane

  3. Re: Warning in geqo_main.c from clang 13

    Tom Lane <tgl@sss.pgh.pa.us> — 2022-01-22T22:34:16Z

    I wrote:
> Thomas Munro <thomas.munro@gmail.com> writes:
>> Clang 13 on my machine and peripatus (but not Apple clang 13 on eg
>> sifika, I'm still confused about Apple's versioning but I think that's
>> really llvm 12-based) warns:
>> geqo_main.c:86:8: warning: variable 'edge_failures' set but not used
>> [-Wunused-but-set-variable]
>> Here's one way to silence it.

> I'm kind of inclined to just drop the edge_failures recording/logging
> altogether, rather than make that rats-nest of #ifdefs even worse.
> It's not like anyone has cared about that number in the last decade
> or two.

We're starting to see more buildfarm animals producing this warning,
so I took another look, and thought of a slightly less invasive way to
silence it.  I confirmed this works with clang 13.0.0 on Fedora 35.

			regards, tom lane

  4. Re: Warning in geqo_main.c from clang 13

    Thomas Munro <thomas.munro@gmail.com> — 2022-01-23T00:47:35Z

    On Sun, Jan 23, 2022 at 11:34 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> We're starting to see more buildfarm animals producing this warning,
> so I took another look, and thought of a slightly less invasive way to
> silence it.  I confirmed this works with clang 13.0.0 on Fedora 35.

LGTM.  Tested on bleeding edge clang 14.

  5. Re: Warning in geqo_main.c from clang 13

    Tom Lane <tgl@sss.pgh.pa.us> — 2022-01-23T16:12:40Z

    Thomas Munro <thomas.munro@gmail.com> writes:
> On Sun, Jan 23, 2022 at 11:34 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> We're starting to see more buildfarm animals producing this warning,
>> so I took another look, and thought of a slightly less invasive way to
>> silence it.  I confirmed this works with clang 13.0.0 on Fedora 35.

> LGTM.  Tested on bleeding edge clang 14.

Pushed, thanks.

			regards, tom lane