Re: ci: Allow running mingw tests by default via environment variable
Thomas Munro <thomas.munro@gmail.com>
From: Thomas Munro <thomas.munro@gmail.com>
To: Andres Freund <andres@anarazel.de>
Cc: Nazir Bilal Yavuz <byavuz81@gmail.com>, pgsql-hackers@postgresql.org, Wolfgang Walther <walther@technowledgy.de>,
Heikki Linnakangas <hlinnaka@iki.fi>, Tomas Vondra <tomas@vondra.me>, Nathan Bossart <nathandbossart@gmail.com>
Date: 2025-04-12T08:18:35Z
Lists: pgsql-hackers
On Tue, Apr 8, 2025 at 1:43 AM Andres Freund <andres@anarazel.de> wrote: > On 2025-04-07 16:03:48 +0300, Nazir Bilal Yavuz wrote: > > On Wed, 5 Mar 2025 at 18:51, Andres Freund <andres@anarazel.de> wrote: > > > I'm inclined to think we should apply to this to all branches with CI support, > > > not just master. It's kind of annoying to have CI infrastructure changes like > > > this that differ between branches. Thoughts? > > > > I am sharing patches per branch until we come up with a better > > solution. Some remarks: > > > > REL_15: It doesn't have any manual tasks, so per repository trigger > > patch (Thomas' patch) is omitted. > > REL_16: Only Mingw task is manual. > > REL_17: Only Mingw task is manual. > > > > While rebasing them, I realized that we use > > 'REPO_CI_AUTOMATIC_TRIGGER_TASKS' for all branches. So, we don't have > > per branch 'REPO_CI_AUTOMATIC_TRIGGER_TASKS' configuration option. Is > > that a problem? > > I think that's not a problem. I can't think of a case where one would want to > do this only for some of the branches. Does anybody disagree? Nope. I think we should push all this stuff and turn it on for cfbot, not only for the benefit of new development but also for the v18 stabilisation period. Is it safe to assume that CI changes come under the same code-freeze exception as tests and docs? I would assume so, it's just scripting glue in .cirrus.XXX files not affecting one bit of the software, but I don't recall that we specifically clarified that before, so can someone from the RMT please +1 this? Then I'll go ahead and push these.
Commits
-
ci: Simplify ci-os-only handling
- b3aa95b61e90 15.15 landed
- 97d6ee571325 18.0 landed
- 60b64e6a31a2 19 (unreleased) landed
- 4900179e9cd8 16.11 landed
- 73f107b54ec6 17.7 landed
-
ci: Per-repo configuration for manually trigger tasks
- 49cba82bec1f 19 (unreleased) landed
- 88f3f7fd831e 15.15 landed
- 965d0a0b8b40 16.11 landed
- 3d478f66b651 17.7 landed
- faa78bc1c1d4 18.0 landed