Re: Why is src/test/modules/committs/t/002_standby.pl flaky?

Thomas Munro <thomas.munro@gmail.com>

From: Thomas Munro <thomas.munro@gmail.com>
To: Andres Freund <andres@anarazel.de>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Alexander Lakhin <exclusion@gmail.com>, Andrew Dunstan <andrew@dunslane.net>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2022-01-25T02:28:45Z
Lists: pgsql-hackers
On Tue, Jan 25, 2022 at 10:28 AM Andres Freund <andres@anarazel.de> wrote:
> On 2022-01-24 15:35:25 -0500, Tom Lane wrote:
> > Andres Freund <andres@anarazel.de> writes:
> > > On 2022-01-14 17:51:52 -0500, Tom Lane wrote:
> > >> FWIW, I'm just fine with reverting, particularly in the back branches.
> > >> It seems clear that this dank corner of Windows contains even more
> > >> creepy-crawlies than we thought.
> >
> > > Seems we should revert now-ish? There's a minor release coming up and I think
> > > it'd be bad to ship these changes to users.
> >
> > Sure.  Do we want to revert in HEAD too?
>
> Not sure. I'm also OK with trying to go with Thomas' patch to walreceiver and
> try a bit longer to get all this working. Thomas?

I vote for reverting in release branches only.  I'll propose a better
WES patch set for master that hopefully also covers async append etc
(which I was already planning to do before we knew about this Windows
problem).  More soon.



Commits

  1. Revert "graceful shutdown" changes for Windows.

  2. Revert "graceful shutdown" changes for Windows, in back branches only.