Horton

Re: CI, macports, darwin version problems

Thomas Munro <thomas.munro@gmail.com>

View thread View on postgr.es
From: Thomas Munro <thomas.munro@gmail.com>
To: Andres Freund <andres@anarazel.de>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, pgsql-hackers <pgsql-hackers@postgresql.org>, Christophe Pettus <christophe.pettus@pgexperts.com>, Joe Conway <mail@joeconway.com>
Date: 2024-07-16T03:19:06Z
Lists: pgsql-hackers

Attachments

On Tue, Jul 16, 2024 at 10:48 AM Andres Freund <andres@anarazel.de> wrote:
> WRT your patches:
> - I think we ought to switch to the -runner image, otherwise we'll just
>   continue to get that "upgraded" warning

Right, let's try it.

> - With a fingerprint_script specified, we need to add
>   reupload_on_changes: true
>   otherwise it'll not be updated.

Ahh, I see.

> - I think the fingerprint_script should use sw_vers, just as the script
>   does. I see no reason to differ?

Yeah might as well.  I started with Darwin versions because that is
what MacPorts complains about, but they move in lockstep.

> - We could just sw_vers -productVersion | sed 's/\..*//g' instead of the more
>   complicated version you used, I doubt that they're going to go away from
>   numerical major versions...

Yep.

I've attached a new version like that.  Let's see which runner machine
gets it and how it turns out...

Commits

  1. ci: Pin MacPorts version to 2.9.3.

  2. ci: Upgrade macOS version from 13 to 14.