Re: Invisible PROMPT2
Thomas Munro <thomas.munro@gmail.com>
From: Thomas Munro <thomas.munro@gmail.com>
To: Maxence Ahlouche <maxence.ahlouche@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2020-02-10T00:30:39Z
Lists: pgsql-hackers
On Mon, Dec 23, 2019 at 5:43 AM Maxence Ahlouche <maxence.ahlouche@gmail.com> wrote: > On Wed, 27 Nov 2019 at 17:09, Tom Lane <tgl@sss.pgh.pa.us> wrote: >> Good idea, but I think you need to account for "visible" (ie, if the >> newline is inside RL_PROMPT_START_IGNORE, it shouldn't change the width). >> It might be best to add logic inside the existing "if (visible)" instead >> of making a new top-level case. > > Right, I assumed that it was safe given that only terminal control characters were invisible. > Since the title of the terminal window can be changed as well via control characters, it's probably better not to make that assumption. > > I updated the patch accordingly. Pushed. Thanks!
Commits
-
psql: Fix %w length in PROMPT2 when PROMPT1 contains a newline.
- 1713a0013f90 13.0 landed
-
Allow invisible PROMPT2 in psql.
- 7f338369ca62 13.0 landed