Re: Windows now has fdatasync()
Thomas Munro <thomas.munro@gmail.com>
From: Thomas Munro <thomas.munro@gmail.com>
To: Robert Haas <robertmhaas@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2022-02-05T01:46:22Z
Lists: pgsql-hackers
On Sat, Feb 5, 2022 at 12:54 PM Robert Haas <robertmhaas@gmail.com> wrote: > On Fri, Feb 4, 2022 at 4:24 PM Thomas Munro <thomas.munro@gmail.com> wrote: > > I'm not proposing we change our default to this new level, because it > > doesn't work on non-NTFS, an annoying complication. This patch would > > just provide something faster to put after "Alternatively". > > Hmm. I thought NTFS had kind of won the filesystem war on the Windows > side of things. No? Against FAT, yes, but there are also SMB/CIFS (network) and the new ReFS (which we recently broke and then unbroke[1]). I haven't tried those things, lacking general Windows-fu, but I suppose they'd reject this and we'd panic, because the docs say "file systems supported: NTFS"[2]. [1] https://www.postgresql.org/message-id/flat/16854-905604506e23d5c0%40postgresql.org [2] https://docs.microsoft.com/en-us/windows-hardware/drivers/ddi/ntifs/nf-ntifs-ntflushbuffersfileex
Commits
-
Remove configure probe for fdatasync.
- d2e150831af8 16.0 landed
-
Remove O_FSYNC and associated macros.
- a1b56090eb54 16.0 landed
-
Fix warnings on Windows.
- bde60daa0ec9 16.0 landed
-
Add wal_sync_method=fdatasync for Windows.
- 9430fb407bb6 16.0 landed