Horton

Thread

Commits

  1. Handle lack of DSM slots in parallel btree build.

  1. Parallel CREATE INDEX vs DSM starvation

    Thomas Munro <thomas.munro@gmail.com> — 2020-01-30T07:37:55Z

    Hello,

CreateParallelContext() can return a context with seg == NULL.  That
causes CREATE INDEX to segfault.  Instead, it should fall back to
non-parallel build.  See attached.

This probably explains a segfault reported over on pgsql-general[1].

[1] https://www.postgresql.org/message-id/CA%2BhUKG%2BcfjHy63hXEOc-CRZEPcUhu9%3DP3gKk_W9OiXzj-dfV_g%40mail.gmail.com

  2. Re: Parallel CREATE INDEX vs DSM starvation

    Peter Geoghegan <pg@bowt.ie> — 2020-01-30T07:47:25Z

    On Wed, Jan 29, 2020 at 11:38 PM Thomas Munro <thomas.munro@gmail.com> wrote:
> CreateParallelContext() can return a context with seg == NULL.  That
> causes CREATE INDEX to segfault.  Instead, it should fall back to
> non-parallel build.  See attached.

I guess we can't call _bt_end_parallel() here. So your patch LGTM.

Thanks
-- 
Peter Geoghegan

  3. Re: Parallel CREATE INDEX vs DSM starvation

    Thomas Munro <thomas.munro@gmail.com> — 2020-01-30T22:35:53Z

    On Thu, Jan 30, 2020 at 8:47 PM Peter Geoghegan <pg@bowt.ie> wrote:
> On Wed, Jan 29, 2020 at 11:38 PM Thomas Munro <thomas.munro@gmail.com> wrote:
> > CreateParallelContext() can return a context with seg == NULL.  That
> > causes CREATE INDEX to segfault.  Instead, it should fall back to
> > non-parallel build.  See attached.
>
> I guess we can't call _bt_end_parallel() here. So your patch LGTM.

Thanks.  Pushed.