Re: Segfault in jit tuple deforming on arm64 due to LLVM issue
Thomas Munro <thomas.munro@gmail.com>
From: Thomas Munro <thomas.munro@gmail.com>
To: Anthonin Bonnefoy <anthonin.bonnefoy@datadoghq.com>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2024-10-17T09:41:05Z
Lists: pgsql-hackers
On Thu, Oct 17, 2024 at 10:36 PM Anthonin Bonnefoy <anthonin.bonnefoy@datadoghq.com> wrote: > I've run some additional tests, mostly pgbench with > options=-cjit_above_cost=0 for an extended duration on an instance > that was impacted. I haven't seen any issues nor performance > regressions compared to the unpatched version. > > I will switch the commitfest entry to Ready for Committer if there's > no objection. Thanks! I'm going to go ahead and commit this. I asked Andres if he wanted to object to this plan (as author of our LLVM stuff) and he did not. I tried, for several frustrating days, to figure out how to solve our problem using JITLink and stay on a more "supported" path, but it all seems a bit unready, as various things don't work or aren't available in various versions in our support range. At least I now have the bones of a patch to prepare for JITLink in LLVM 20 or whenever they force our hand... I'll write about that in a new thread soon.
Commits
-
Monkey-patch LLVM code to fix ARM relocation bug.
- 9044fc1d45a0 18.0 landed
- 50c1453a308d 12.21 landed
- e88d824a4127 13.17 landed
- 0b022ddf3e30 14.14 landed
- 19bf81c06a37 15.9 landed
- ee67b73f5902 16.5 landed
- b7467ab71c19 17.1 landed