Re: index prefetching
Thomas Munro <thomas.munro@gmail.com>
Commits
GET /api/v1/messages/:b64id/commits
the thread's linked commits as JSON, with link sources.
API reference →
-
aio: io_uring: Trigger async processing for large IOs
- a9ee66881744 19 (unreleased) landed
-
read stream: Split decision about look ahead for AIO and combining
- 8ca147d582a5 19 (unreleased) landed
-
read_stream: Only increase read-ahead distance when waiting for IO
- f63ca3379025 19 (unreleased) landed
-
read_stream: Prevent distance from decaying too quickly
- 6e36930f9aaf 19 (unreleased) landed
-
Reduce ExecSeqScan* code size using pg_assume()
- b227b0bb4e03 19 (unreleased) cited
-
Fix rare bug in read_stream.c's split IO handling.
- b421223172a2 19 (unreleased) cited
-
Fix multiranges to behave more like dependent types.
- 3e8235ba4f9c 17.0 cited
-
Add EXPLAIN (MEMORY) to report planner memory consumption
- 5de890e3610d 17.0 cited
-
Optimize nbtree backward scan boundary cases.
- c9c0589fda0e 17.0 cited
-
Increment xactCompletionCount during subtransaction abort.
- 90c885cdab8b 14.0 cited
-
Add nbtree Valgrind buffer lock checks.
- 4a70f829d86c 14.0 cited
-
Add nbtree high key "continuescan" optimization.
- 29b64d1de7c7 12.0 cited
-
Reduce pinning and buffer content locking for btree scans.
- 2ed5b87f96d4 9.5.0 cited
-
Teach btree to handle ScalarArrayOpExpr quals natively.
- 9e8da0f75731 9.2.0 cited
Attachments
- 0001-aio-Refactor-read_stream.c-end-of-stream-state.txt (text/plain)
- 0002-aio-Add-READ_STREAM_RESET_CONTINUE-flag.txt (text/plain)
- 0003-aio-Improve-read_stream.c-look-ahead-heuristics-A.txt (text/plain)
- 0003-aio-Improve-read_stream.c-look-ahead-heuristics-B.txt (text/plain)
On Sun, Jul 20, 2025 at 1:07 AM Thomas Munro <thomas.munro@gmail.com> wrote: > On Sat, Jul 19, 2025 at 11:23 PM Tomas Vondra <tomas@vondra.me> wrote: > > Thanks for the link. It seems I came up with an almost the same patch, > > with three minor differences: > > > > 1) There's another place that sets "distance = 0" in > > read_stream_next_buffer, so maybe this should preserve the distance too? > > > > 2) I suspect we need to preserve the distance at the beginning of > > read_stream_reset, like > > > > stream->reset_distance = Max(stream->reset_distance, > > stream->distance); > > > > because what if you call _reset before reaching the end of the stream? > > > > 3) Shouldn't it reset the reset_distance to 0 after restoring it? > > Probably. Hmm... an earlier version of this code didn't use distance > == 0 to indicate end-of-stream, but instead had a separate internal > end_of_stream flag. If we brought that back and didn't clobber > distance, we wouldn't need this save-and-restore dance. It seemed > shorter and sweeter without it back then, before _reset() existed in > its present form, but I wonder if end_of_stream would be nicer than > having to add this kind of stuff, without measurable downsides. ... > Good question. Yeah, your flag idea seems like a good way to avoid > baking opinion into this level. I wonder if it should be a bitmask > rather than a boolean, in case we think of more things that need to be > included or not when resetting. Here's a sketch of the above two ideas for discussion (.txt to stay off cfbot's radar for this thread). Better than save/restore? Here also are some alternative experimental patches for preserving accumulated look-ahead distance better in cases like that. Needs more exploration... thoughts/ideas welcome...