Horton

Re: GlobalVisIsRemovableFullXid() vs GlobalVisCheckRemovableXid()

Thomas Munro <thomas.munro@gmail.com>

View thread View on postgr.es
From: Thomas Munro <thomas.munro@gmail.com>
To: Peter Geoghegan <pg@bowt.ie>
Cc: Andres Freund <andres@anarazel.de>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2021-02-15T00:20:29Z
Lists: pgsql-hackers 
On Mon, Feb 15, 2021 at 11:33 AM Peter Geoghegan <pg@bowt.ie> wrote:
> On Sun, Feb 14, 2021 at 2:08 PM Thomas Munro <thomas.munro@gmail.com> wrote:
> > I prefer "next", because that's in the name of the variable it reads,
> > and the variable name seemed to me to have a more obvious meaning.
> > That's why I went for that name in commit 2fc7af5e966.  I do agree
> > that it's slightly strange that the 32 and 64 bit versions differ
> > here.  I'd vote for renaming the 32 bit version to match...
>
> I was just going to say the same thing myself.
>
> Please do the honors if you have time...

Done.

Commits

  1. ReadNewTransactionId() -> ReadNextTransactionId().

  2. Rename removable xid function for consistency.

  3. Add basic infrastructure for 64 bit transaction IDs.