Re: Why is src/test/modules/committs/t/002_standby.pl flaky?
Thomas Munro <thomas.munro@gmail.com>
From: Thomas Munro <thomas.munro@gmail.com>
To: Andres Freund <andres@anarazel.de>
Cc: Alexander Lakhin <exclusion@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>, Andrew Dunstan <andrew@dunslane.net>,
pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2022-01-15T00:19:42Z
Lists: pgsql-hackers
On Sat, Jan 15, 2022 at 11:44 AM Andres Freund <andres@anarazel.de> wrote: > > The patch Alexander tested most recently uses a tri-state eof flag [...] > > What about instead giving WalReceiverConn an internal WaitEventSet, and using > that consistently? I've attached a draft for that. > > Alexander, could you test with that patch applied? Isn't your patch nearly identical to one that I already posted, that Alexander tested and reported success with here? https://www.postgresql.org/message-id/5d507424-13ce-d19f-2f5d-ab4c6a987316%40gmail.com I can believe that fixes walreceiver (if we're sure that there isn't a libpq-changes-the-socket problem), but AFAICS the same problem exists for postgres_fdw and async append. That's why I moved to trying to fix the multiple-WES thing (though of course I agree we should be using long lived WESes wherever possible, I just didn't think that seemed back-patchable, so it's more of a feature patch for the future).
Commits
-
Revert "graceful shutdown" changes for Windows.
- 29992a6a509b 15.0 landed
-
Revert "graceful shutdown" changes for Windows, in back branches only.
- bbb1caf6b220 11.15 landed
- 75674c7ec1b1 14.2 landed
- 64b2c6507e57 12.10 landed
- 645c9457f296 10.20 landed
- 213c5aa3bdba 13.6 landed