Horton

Re: pgbench logging broken by time logic changes

Thomas Munro <thomas.munro@gmail.com>

View thread View on postgr.es
From: Thomas Munro <thomas.munro@gmail.com>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Michael Paquier <michael@paquier.xyz>, Fabien COELHO <coelho@cri.ensmp.fr>, Gregory Smith <gregsmithpgsql@gmail.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>, david.christensen@crunchydata.com
Date: 2021-06-20T07:38:50Z
Lists: pgsql-hackers 
On Sun, Jun 20, 2021 at 4:52 PM Thomas Munro <thomas.munro@gmail.com> wrote:
> On Sun, Jun 20, 2021 at 3:18 PM Alvaro Herrera <alvherre@alvh.no-ip.org> wrote:
> > On 2021-Jun-19, Thomas Munro wrote:
> > > Thanks for looking so far.  It's the weekend here and I need to
> > > unplug, but I'll test these changes and if all looks good push on
> > > Monday.
> >
> > Surely not the same day as the beta stamp...
>
> Because of timezones, that'll be Sunday in the Americas.  Still too close?

Upon reflection, that amounts to the same thing really, so yeah,
scratch that plan.  I'll defer until after that (and then I'll be
leaning more towards the revert option).

Commits

  1. Fix pgbench timestamp bugs.

  2. Fix pattern matching logic for logs in TAP tests of pgbench

  3. pgbench: Improve time logic.

  4. pgbench: Synchronize client threads.

  5. pgbench: refactor handling of stats tracking