Re: CFbot does not recognize patch contents
Thomas Munro <thomas.munro@gmail.com>
From: Thomas Munro <thomas.munro@gmail.com>
To: Tatsuo Ishii <ishii@sraoss.co.jp>
Cc: byavuz81@gmail.com, pgsql-hackers@postgresql.org
Date: 2024-05-15T02:54:39Z
Lists: pgsql-hackers
On Sun, May 12, 2024 at 10:11 PM Tatsuo Ishii <ishii@sraoss.co.jp> wrote: > > I am able to apply all your patches. I found that a similar thing > > happened before [0] and I guess your case is similar. Adding Thomas to > > CC, he may be able to help more. > > Ok. Thanks for the info. This obviously fixed itself automatically soon after this message, but I figured out what happened: I had not actually fixed that referenced bug in cfbot :-(. It was checking for HTTP error codes correctly in the place that reads emails from the archives, but not the place that downloads patches, so in this case I think when it tried to follow the link[1] to download the patch, I guess it must have pulled down a transient Varnish error message (I don't know what, I don't store it anywhere), and tried to apply that as a patch. Oops. Fixed[2]. [1] https://www.postgresql.org/message-id/attachment/160138/v18-0001-Row-pattern-recognition-patch-for-raw-parser.patch [2] https://github.com/macdice/cfbot/commit/ec33a65a877a88befc29ea220e87b98c89b27dcc
Commits
-
doc PG 17 relnotes: move FETCH_COUNT item, and clarify
- 31e8f4e619d9 17.0 cited