Horton

Re: race condition when writing pg_control

Thomas Munro <thomas.munro@gmail.com>

View thread View on postgr.es
From: Thomas Munro <thomas.munro@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: "Bossart, Nathan" <bossartn@amazon.com>, Fujii Masao <masao.fujii@oss.nttdata.com>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Date: 2020-06-08T02:48:55Z
Lists: pgsql-hackers 
On Wed, Jun 3, 2020 at 2:03 PM Michael Paquier <michael@paquier.xyz> wrote:
> On Wed, Jun 03, 2020 at 10:56:13AM +1200, Thomas Munro wrote:
> > Sorry for my radio silence, I got tangled up with a couple of
> > conferences.  I'm planning to look at 0001 and 0002 shortly.
>
> Thanks!

I pushed 0001 and 0002, squashed into one commit.  I'm not sure about
0003.  If we're going to do that, wouldn't it be better to just
acquire the lock in that one extra place in StartupXLOG(), rather than
introducing the extra parameter?

Commits

  1. Fix locking bugs that could corrupt pg_control.