Horton

Re: Cleaning up threading code

Thomas Munro <thomas.munro@gmail.com>

View thread View on postgr.es
From: Thomas Munro <thomas.munro@gmail.com>
To: Andres Freund <andres@anarazel.de>
Cc: Heikki Linnakangas <hlinnaka@iki.fi>, Peter Eisentraut <peter@eisentraut.org>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2023-07-12T05:27:49Z
Lists: pgsql-hackers 
On Wed, Jul 12, 2023 at 3:34 PM Thomas Munro <thomas.munro@gmail.com> wrote:
> On Wed, Jul 12, 2023 at 3:21 PM Thomas Munro <thomas.munro@gmail.com> wrote:
> > Apparently "drongo" didn't like something about this commit, and an
> > ecpg test failed, but I can't immediately see why.  Just "server
> > closed the connection unexpectedly".  drongo is running the new Meson
> > buildfarm variant on Windows+MSVC, so, being still in development, I
> > wonder if some diagnostic clue/log/backtrace etc is not being uploaded
> > yet.  FWIW Meson+Windows+MSVC passes on CI.
>
> Oh, that's probably unrelated to this commit.  It's failed 6 times
> like that in the past ~3 months.

Ah, right, that is a symptom of the old Windows TCP linger vs process
exit thing.  Something on my list to try to investigate again, but not
today.

https://www.postgresql.org/message-id/flat/16678-253e48d34dc0c376%40postgresql.org

Commits

  1. Doc: Adjust libpq docs about thread safety.

  2. Remove --disable-thread-safety and related code.

  3. Rename port/thread.c to port/user.c.

  4. Remove obsolete comment and code from fe-auth.c.