Horton

Re: Windows pg_basebackup unable to create >2GB pg_wal.tar tarballs ("could not close file: Invalid argument" when creating pg_wal.tar of size ~ 2^31 bytes)

Thomas Munro <thomas.munro@gmail.com>

View thread View on postgr.es
From: Thomas Munro <thomas.munro@gmail.com>
To: Andrew Dunstan <andrew@dunslane.net>
Cc: Robert Haas <robertmhaas@gmail.com>, Jakub Wartak <jakub.wartak@enterprisedb.com>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>, Dilip Kumar <dilip.kumar@enterprisedb.com>
Date: 2025-01-09T03:11:27Z
Lists: pgsql-hackers 
On Tue, Jan 7, 2025 at 9:54 AM Thomas Munro <thomas.munro@gmail.com> wrote:
> On Tue, Jan 7, 2025 at 5:23 AM Andrew Dunstan <andrew@dunslane.net> wrote:
> > Do you have a plan for moving ahead with this?
>
> I think that all looks good, and I'll go ahead and commit it in the
> next day or two.  Sorry for the delay.

I changed some remaining off_t, because I don't want to worry about
which ones can and can't overflow.  Might as we'll get 'em all.  I
also noticed a warning due to the new lseek() macro, which just
required adding it to plperl_system.h.

And pushed.

Commits

  1. Fix off_t overflow in pg_basebackup on Windows.

  2. Provide 64-bit ftruncate() and lseek() on Windows.

  3. Require ucrt if using MinGW.