Horton

Re: BUG #17391: While using --with-ssl=openssl and PG_TEST_EXTRA='ssl' options, SSL tests fail on OpenBSD 7.0

Thomas Munro <thomas.munro@gmail.com>

View thread View on postgr.es
From: Thomas Munro <thomas.munro@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Daniel Gustafsson <daniel@yesql.se>, Andres Freund <andres@anarazel.de>, byavuz81@gmail.com, PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>, Heikki Linnakangas <heikki.linnakangas@iki.fi>, Michael Paquier <michael@paquier.xyz>
Date: 2022-02-12T23:25:06Z
Lists: pgsql-bugs 
On Sun, Feb 13, 2022 at 10:56 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> I went ahead and pushed the patches-under-discussion (the larger
> one only to HEAD, for now).  I've confirmed that the ssl tests
> are solid now under OpenBSD 7.0, on bare metal as well as on the
> VM I was using before.  They are still broken under OpenBSD 6.8,
> which seems interesting but not so interesting that I want to
> spend more time on it (seeing that 6.8 is EOL as far as
> openbsd.org is concerned).  Does anyone want to recheck 6.9?

Looks good:

t/001_ssltests.pl .. ok
t/002_scram.pl ..... ok
t/003_sslinfo.pl ... ok
All tests successful.
Files=3, Tests=134, 28 wallclock secs ( 0.04 usr  0.03 sys +  4.87
cusr  7.27 csys = 12.21 CPU)
Result: PASS
gmake: Leaving directory '/home/vagrant/postgres/src/test/ssl'
-bash-5.1$ uname -a
OpenBSD openbsd6.localdomain 6.9 GENERIC.MP#473 amd64

Commits

  1. Move libpq's write_failed mechanism down to pqsecure_raw_write().

  2. Fix thinko in PQisBusy().

  3. Set SNI ClientHello extension to localhost in tests

  4. Improve worst-case performance of text_position_get_match_pos()