Horton

Re: Tests "with" and "alter_table" suffer from name clash

Thomas Munro <thomas.munro@gmail.com>

View thread View on postgr.es
From: Thomas Munro <thomas.munro@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2021-12-30T04:25:40Z
Lists: pgsql-hackers 
On Thu, Dec 30, 2021 at 3:27 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Looks reasonable.  We really should avoid using such common
> names for short-lived tables in any case --- it's an invitation
> to trouble.  So I'd vote for changing the other use of "test", too.

In fact only REL_10_STABLE had the problem, because commit 2cf8c7aa
already fixed the other instance in later branches.  I'd entirely
forgotten that earlier discussion, which apparently didn't quite go
far enough.   So I only needed to push the with.sql change.  Done.

Commits

  1. Fix overly generic name in with.sql test.

  2. Clean up duplicate table and function names in regression tests.