Re: kevent latch paths don't handle postmaster death well
Thomas Munro <thomas.munro@gmail.com>
From: Thomas Munro <thomas.munro@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Heikki Linnakangas <hlinnaka@iki.fi>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2020-10-14T19:36:37Z
Lists: pgsql-hackers
On Thu, Oct 15, 2020 at 7:58 AM Tom Lane <tgl@sss.pgh.pa.us> wrote: > We appear to have already realized that the postmaster died, since we're > inside proc_exit. WaitForBackgroundWorkerShutdown is doing this: > > rc = WaitLatch(MyLatch, > WL_LATCH_SET | WL_POSTMASTER_DEATH, 0, > WAIT_EVENT_BGWORKER_SHUTDOWN); > > which one would certainly hope would not block at all if the postmaster > is already dead, yet it's doing so. I guess that the kevent stuff is > failing to handle the case of another WaitLatch call after the postmaster > is already known dead. The process exit event is like an 'edge', not a 'level'... hmm. It might be enough to set report_postmaster_not_running = true the first time it tells us so if we try to wait again we'll treat it like a level. I will look into it later today.
Commits
-
Handle EACCES errors from kevent() better.
- 47522ee00ddb 13.1 landed
- 70516a178ad0 14.0 landed
-
Make WL_POSTMASTER_DEATH level-triggered on kqueue builds.
- e0950135ae5d 13.1 landed
- b94109ce375b 14.0 landed