Re: Dead code in ps_status.c
Thomas Munro <thomas.munro@gmail.com>
From: Thomas Munro <thomas.munro@gmail.com>
To: Michael Banck <mbanck@gmx.net>
Cc: Tom Lane <tgl@sss.pgh.pa.us>,
pgsql-hackers <pgsql-hackers@postgresql.org>, Andres Freund <andres@anarazel.de>
Date: 2025-11-17T22:24:40Z
Lists: pgsql-hackers
On Mon, Nov 17, 2025 at 10:36 PM Michael Banck <mbanck@gmx.net> wrote: > I mentioned that in a follow-up[0] to my original mail that you > apparently did not see eiter: > > |By the way, on the back branches from 13-15 (before the above commit) > |process title changes don't work either, presumably because __hurd__ (as > |opposed to __GNU__ and __gnu_hurd__) has not been defined on GNU/Hurd > |for ages (or ever?), see > |https://github.com/gcc-mirror/gcc/blob/master/gcc/config/gnu.h#L25 > | > |So in case this get backpatched, I think it should be changed to > |PS_USE_CLOBBER_ARGV there as well. > > So yeah, I think those would be useful to fix. If you have a patch, I am > happy to test it, or I can come up with one (but not sure I manage this > week). Ahh, yeah, I'd missed that one too. The mail is definitely getting through now, though. With that information, it seemed pretty clear what to do, so I went ahead and back-patched to 14 and 15.
Commits
Same data as JSON:
GET /api/v1/messages/:b64id/commits
the thread's linked commits as JSON, with link sources.
API reference →
-
Define PS_USE_CLOBBER_ARGV on GNU/Hurd.
- 29a3e22f3568 14.21 landed
- 3995e4a9d8c6 15.16 landed
- 32b236644d33 19 (unreleased) landed
- bcfca332f100 18.2 landed
- d66a922f9247 17.8 landed
- a1407daded69 16.12 landed
-
Remove obsolete platforms from ps_status.c.
- d2ea2d310dfd 16.0 landed