Horton

Re: Cleaning up threading code

Thomas Munro <thomas.munro@gmail.com>

View thread View on postgr.es
From: Thomas Munro <thomas.munro@gmail.com>
To: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: Peter Eisentraut <peter@eisentraut.org>, Andres Freund <andres@anarazel.de>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2023-07-09T22:45:04Z
Lists: pgsql-hackers

Attachments

Thanks all for the reviews.  I pushed the first two small patches.
Here is a new version of the main --disable-thread-safety removal
part, with these changes:

* fixed LDAP_LIBS_FE snafu reported by Peter E
* defined ENABLE_THREAD_SAFETY 1 in c.h, for the benefit of extensions
* defined ENABLE_THREAD_SAFETY 1 ecpg_config.h, for the benefit of ECPG clients
* added Heikki's doc change as a separate patch (with minor xml snafu fixed)

I'll follow up with a new version of the later pg_threads.h proposal
and responses to feedback on that after getting this basic clean-up
work in.  Any other thoughts on this part?

Commits

  1. Doc: Adjust libpq docs about thread safety.

  2. Remove --disable-thread-safety and related code.

  3. Rename port/thread.c to port/user.c.

  4. Remove obsolete comment and code from fe-auth.c.