Horton
Menu

Re: Dead code in ps_status.c

Thomas Munro <thomas.munro@gmail.com>

View thread
From: Thomas Munro <thomas.munro@gmail.com>
To: Michael Banck <mbanck@gmx.net>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, pgsql-hackers <pgsql-hackers@postgresql.org>, Andres Freund <andres@anarazel.de>
Date: 2025-11-10T22:04:00Z
Lists: pgsql-hackers 
Replying to Michael's message:

https://www.postgresql.org/message-id/68adbcd3.500a0220.8d4c9.9460%40mx.google.com

Sorry I missed this.  I had some trouble with your messages being
deleted as spam, which I've hopefully fixed now...

-#elif defined(__linux__) || defined(__sun) || defined(__darwin__)
+#elif defined(__linux__) || defined(__sun) || defined(__darwin__) ||
defined(__GNU__)

Would __gnu_hurd__ be a better bet, less confusable with GNU userspace
stuff?  I think these platform macros might come from this file in
GCC:

https://github.com/gcc-mirror/gcc/blob/faf7053346110cbd11fb22ff75f56a964047b19c/gcc/config/gnu.h#L30

But maybe not only there, if __hurd__ (as removed by d2ea2d31)
actually worked...

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Define PS_USE_CLOBBER_ARGV on GNU/Hurd.

  2. Remove obsolete platforms from ps_status.c.