Horton

Re: fairywren hung in pg_basebackup tests

Thomas Munro <thomas.munro@gmail.com>

View thread View on postgr.es
From: Thomas Munro <thomas.munro@gmail.com>
To: Andrew Dunstan <andrew@dunslane.net>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Alvaro Herrera <alvherre@alvh.no-ip.org>, Noah Misch <noah@leadboat.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2022-07-28T02:12:13Z
Lists: pgsql-hackers 
On Thu, Jul 28, 2022 at 12:41 PM Thomas Munro <thomas.munro@gmail.com> wrote:
> I thought about putting it at the top, but don't we really only need
> to make an extra system call if MinGW's stat() told us it saw a
> directory?  And what if you asked to look through symlinks?  I thought
> about putting it near the S_ISLNK() test, which is the usual pattern,
> but then what if MinGW decides to add d_type support one day?  Those
> thoughts led to the attached formulation.  Untested.  I'll go and try
> to see if I can run this with Melih's proposed MSYS CI support...

Success.  I'll push this, and then hopefully those BF animals can be
unwedged.  (I see some unrelated warnings to look into.)

https://cirrus-ci.com/task/5253183533481984?logs=tests#L835

Commits

  1. Fix get_dirent_type() for symlinks on MinGW/MSYS.