Re: An out-of-date comment in nodeIndexonlyscan.c

Thomas Munro <thomas.munro@gmail.com>

From: Thomas Munro <thomas.munro@gmail.com>

To: David Rowley <dgrowleyml@gmail.com>

Cc: Ashwin Agrawal <aagrawal@pivotal.io>, Pg Hackers <pgsql-hackers@postgresql.org>, Heikki Linnakangas <hlinnaka@iki.fi>, Kevin Grittner <kgrittn@gmail.com>

Date: 2021-06-13T22:03:08Z

Lists: pgsql-hackers

Attachments

v3-0001-Use-tuple-level-SIREAD-locks-for-index-only-scans.patch (text/x-patch) patch v3-0001
v3-0002-WIP-Skip-SIREAD-locks-on-btree-pages-when-possibl.patch (text/x-patch) patch v3-0002

On Mon, Jun 14, 2021 at 12:54 AM David Rowley <dgrowleyml@gmail.com> wrote:
> I think a more optimal and nicer way of doing that would be setting
> bits in a Bitmapset then checking bms_num_members is equal to
> n_scan_keys.

Shouldn't it be compared with indnkeyatts?  Yes, much nicer, thanks!

Commits

Block ALTER INDEX/TABLE index_name ALTER COLUMN colname SET (options)
- fdd88571454e 15.0 cited
Fix misleading comment in nodeIndexonlyscan.c.
- 706cb9bf4f43 9.4.24 landed
- d7395cf608e7 9.5.19 landed
- 0908c5ecf083 9.6.15 landed
- 69da8c1e69ef 10.10 landed
- 6827e46cdf35 11.5 landed
- 74b7cc8c0213 12.0 landed
Eliminate xmin from hash tag for predicate locks on heap tuples.
- c01262a82484 9.4.0 cited
Fix serializable mode with index-only scans.
- cdf91edba9f9 9.3.0 cited