Horton
Menu

Re: Re: proposal: make NOTIFY list de-duplication optional

Thomas Munro <thomas.munro@gmail.com>

View thread
From: Thomas Munro <thomas.munro@gmail.com>
To: Filip Rembiałkowski <filip.rembialkowski@gmail.com>
Cc: Pgsql Hackers <pgsql-hackers@postgresql.org>, Catalin Iacob <iacobcatalin@gmail.com>, David Steele <david@pgmasters.net>
Date: 2019-03-09T02:30:40Z
Lists: pgsql-hackers 
On Fri, Mar 8, 2019 at 1:37 PM Filip Rembiałkowski
<filip.rembialkowski@gmail.com> wrote:
> See attached patch... I'm ready to work on so it can get merged in the next CF.

Hi Filip,

Seen on Travis:

     async                        ... FAILED      126 ms

Looks like the new error isn't being raised for invalid send mode?
(What kind of error message is "?" anyway? :-))

 ERROR:  channel name too long
 -- Should fail. Invalid 3rd parameter
 NOTIFY notify_async2, 'test', 'invalid';
-ERROR:  ?
 NOTIFY notify_async2, 'test', true;
-ERROR:  ?
 --Should work. Valid NOTIFY/LISTEN/UNLISTEN commands
 NOTIFY notify_async2;
 NOTIFY notify_async2, '';

-- 
Thomas Munro
https://enterprisedb.com

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Use a hash table to de-duplicate NOTIFY events faster.